Charting tool enhancements - Errors bars for Bar and Line chart#7117
Merged
Charting tool enhancements - Errors bars for Bar and Line chart#7117
Conversation
…ons for SD and SEM
…e if > 10 labels and wrapping text otherwise)
…tAggregateData() for measure value
…or line chart and bar chart case with aggregate and aggErrorType
…error bars options on yaxis layout panel
…rt test failure case)
This was referenced Oct 13, 2025
Merged
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds error bar functionality for bar and line charts in the charting tool, allowing users to display standard deviation or standard error of the mean when using mean aggregation. The changes enhance the existing visualization components to support error bars, including UI controls for configuration and statistical calculations for SD/SEM values.
Key changes include:
- Addition of error bar support for bar and line charts with vertical error bars
- New UI controls for aggregate method selection and error bar type configuration
- Enhanced statistical functions for calculating standard deviation and standard error of the mean
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| timeChartHelper.js | Updates error bar configuration to show vertical error bars |
| genericChartHelper.js | Major refactoring to support error bars, axis text wrapping, and data aggregation |
| genericChartPanel.js | Refactored chart panel to use shared data generation logic |
| genericChartAxisPanel.js | Added UI controls for aggregate method and error bar selection |
| utils.js | Enhanced data aggregation and value extraction to support error calculations |
| statistics.js | Added standard error function and improved standard deviation calculation |
| plot.js | Updated default tick overlap rotation angle |
| D3Renderer.js | Enhanced error bar rendering and axis text wrapping functionality |
| geom.js | Added vertical error bar configuration option |
| index.html | Added LABKEY global variable initialization |
| utils.test.ts | New test file for utility functions |
| statistics.test.ts | New test file for statistical functions |
Comments suppressed due to low confidence (1)
visualization/resources/web/vis/chartWizard/chartLayoutDialog/genericChartAxisPanel.js:1
- The nullish coalescing operator (??) may not be supported in older browsers. Consider using a conditional check or logical OR (||) operator for better compatibility.
/*
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
visualization/resources/web/vis/genericChart/genericChartHelper.js
Outdated
Show resolved
Hide resolved
visualization/resources/web/vis/genericChart/genericChartHelper.js
Outdated
Show resolved
Hide resolved
labkey-alan
requested changes
Oct 15, 2025
visualization/resources/web/vis/genericChart/genericChartHelper.js
Outdated
Show resolved
Hide resolved
visualization/resources/web/vis/genericChart/genericChartHelper.js
Outdated
Show resolved
Hide resolved
visualization/resources/web/vis/genericChart/genericChartHelper.js
Outdated
Show resolved
Hide resolved
visualization/resources/web/vis/genericChart/genericChartHelper.js
Outdated
Show resolved
Hide resolved
…ons, default value in param, replace square bracket accessor
… bar chart modals
…r has set max manually)
… aggregate/error bars for one left y-axis measure)
… aggregate/error bars for one left y-axis measure)
labkey-alan
approved these changes
Oct 16, 2025
…value for sorting
…inuousAcc, but account for value vs formatted value in acc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
See related ui-components PR for rationale. This PR
Related Pull Requests
Changes